Skip to content

Add rank_llm ordered quality gate#374

Draft
branta42 wants to merge 1 commit intomainfrom
rank-llm-mypy-gate-1
Draft

Add rank_llm ordered quality gate#374
branta42 wants to merge 1 commit intomainfrom
rank-llm-mypy-gate-1

Conversation

@branta42
Copy link
Copy Markdown
Member

ref: N/A

Summary

  • add a repo-local ordered quality gate for rank_llm
  • enforce Ruff, offline tests, then MyPy in hooks and PR CI
  • introduce an initial strict MyPy scope for the modern CLI/API surface

Why

  • rank_llm previously had Ruff-only hook/CI enforcement and no static type gate
  • pushes could succeed locally without running the same test/type sequence the repo now expects

Validation

  • .venv/bin/python -m ruff check .
  • .venv/bin/python -m ruff format --check .
  • .venv/bin/python -m mypy
  • .venv/bin/python scripts/quality_gate.py
  • .venv/bin/python -m pre_commit run --all-files
  • .venv/bin/python -m pre_commit run --hook-stage pre-push --all-files

Follow-ups

  • expand the strict MyPy scope in subsequent stacked PRs to retrieval, server, scripts, training, and other legacy surfaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants